Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let request error override responses #819

Merged
merged 1 commit into from
Dec 25, 2015
Merged

Don't let request error override responses #819

merged 1 commit into from
Dec 25, 2015

Conversation

clayreimann
Copy link
Contributor

Talking to certain servers I was seeing the following error, even when the response was 200 OK

Error: read ECONNRESET
    at exports._errnoException (util.js:855:11)
    at TCP.onread (net.js:544:26)

@clayreimann
Copy link
Contributor Author

How can I kick off the Sauce tests again? (and why are they always so flakey?)

@kornelski
Copy link
Contributor

I've restarted tests (you can do that by clicking details, then failed test, and a refresh button in top right)

@focusaurus
Copy link
Contributor

LGTM

kornelski added a commit that referenced this pull request Dec 25, 2015
@kornelski
Merge pull request #819 from clayreimann/prevent-request-error-from-s…
3768360 
…quashing-response

Don't let request error override responses
@kornelski kornelski merged commit 3768360 into ladjs:master Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clayreimann @kornelski @focusaurus