Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports http2 #793

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat: supports http2 #793

merged 1 commit into from
Oct 4, 2022

Conversation

lamweili
Copy link
Contributor

@lamweili lamweili commented Oct 3, 2022

superagent@8.x already has http2 support.
This PR enables the http2 support on supertest as well.

As this is a new feature (backward compatible and non-breaking), following semver, a minor version jump is required.


Tests are using Node.js native http2 module to create the server with 100% test coverage.

  • The http2 tests are not using express (as express@4.x does not support http2)
  • supertest should not be reliant on express anyway

@lamweili
Copy link
Contributor Author

lamweili commented Oct 3, 2022

The tests are failing in the CI because of coveralls. Refer to PR #794.


I commented the following away in my forked repository.

https://github.com/visionmedia/supertest/blob/e064b5ae71e1dfa3e1a74745fda527ac542e1878/.github/workflows/node.js.yml#L38-L40

The tests passed: https://github.com/lamweili/supertest/actions/runs/3177809614

This was referenced Oct 4, 2022
@titanism titanism merged commit 22b89b6 into ladjs:master Oct 4, 2022
@lamweili
Copy link
Contributor Author

lamweili commented Oct 4, 2022

Thanks, @titanism!


PS: You might want to close the following issues/PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants