feat: Add private bucket option #58
Merged
+760
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublicly accessible.
…d files into this folder). Moving methods to generate name in helper files. Prettier also applied some changes here and there.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 85.86% 83.14% -2.72%
==========================================
Files 12 13 +1
Lines 375 451 +76
Branches 78 85 +7
==========================================
+ Hits 322 375 +53
- Misses 53 76 +23 ☔ View full report in Codecov by Sentry. |
fTrestour
approved these changes
May 28, 2024
src/cloudfront/origin-access.ts
Outdated
Comment on lines
101
to
103
| if (isOACAlreadyAssociated) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
It looks like you could directly return isOACAlreadyAssociated
src/cloudfront/origin-access.ts
Outdated
Comment on lines
110
to
114
| if (isS3WebsiteAlreadyAssociated) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Same here and you wouldn't need to do the late return
src/s3.ts
Outdated
| @@ -95,6 +95,20 @@ export const tagBucket = async (bucketName: string) => { | |||
| .promise(); | |||
| }; | |||
|
|
|||
| export const removeBucketWebsite = (bucketName: string) => { | |||
| logger.info( | |||
| `[S3] 🔏 Ensure bucket "${bucketName}" is not a static website hoisting` | |||
GregdTd
force-pushed
the
add-private-bucket-option
branch
from
51d7529
to
f482763
Compare
fTrestour
approved these changes
May 28, 2024
GregdTd
force-pushed
the
add-private-bucket-option
branch
from
cf5a3f8
to
f87f8a8
Compare
…s Control that will be fetched or created for the occasion. The distribution can be updated in both way, either by adding an OAC or on the contrary removing an OAC and add an s3-website-hoisting url.
…bucket policy with an OAC
GregdTd
force-pushed
the
add-private-bucket-option
branch
from
f87f8a8
to
e591dc5
Compare
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.