Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to fill video to screen #239

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat: add option to fill video to screen #239

merged 2 commits into from
Jul 19, 2023

Conversation

stickyburn
Copy link
Contributor

Based on #51 , this PR adds an option to enable 'fill to screen'. If enabled, the video is filled when maximized.

image

Copy link
Owner

@lamarios lamarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, code looks good. I'll have to test it on my own before merging.

@lamarios
Copy link
Owner

I had a look while it does what it says, wouldn't it be better if it is on a video basis ? with like a pinch gesture when the video is playing full screen ?

@lamarios
Copy link
Owner

I did some tests on the video player library to implement it (as i keep my own fork) and it won't be easy as it looks like changing the fit of the video doesn't update live on a full screen video (unless i go back and forth from and to full screen). I'll need to dig deeper on this.

@stickyburn
Copy link
Contributor Author

I had a look while it does what it says, wouldn't it be better if it is on a video basis ? with like a pinch gesture when the video is playing full screen ?

This is what I initially desired but would require some pointers on. Do we merge this or come back to it later?

@lamarios
Copy link
Owner

I had a look while it does what it says, wouldn't it be better if it is on a video basis ? with like a pinch gesture when the video is playing full screen ?

This is what I initially desired but would require some pointers on. Do we merge this or come back to it later?

This is a bit more involved. I"m actually using an abandoned library for the video player that i forked and keep afloat. The changes would need to be there because once in full screen it doesn't respond to gestures if implemented in the application itself.

I want to rewrite the player to use the base video_player library but that will require a lot of work to reach feature parity

@stickyburn
Copy link
Contributor Author

I understand. I think it's nice to have atleast this option for now. Wdyt?

@lamarios
Copy link
Owner

sure, let's merge it

@lamarios lamarios merged commit 2384f81 into lamarios:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants