You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While this is convenient, it's problematic because:
Weird edge cases. See impl Render for borrows ? #266. While that particular case could be solved with an impl Render for &PreEscaped<T>, I'd rather go for a more general solution.
Performance. The std::fmt machinery is pretty heavyweight, and building Render on top of it locks us out of making it faster. In fact, this is the reason why markup.rs beats Maud in benchmarks – they use the itoa crate to render integers.
Semantics. There's no particular reason why the text and HTML representations should be tied together.
As part of this change, we should:
Add manual impls for integer types.
Investigate impact on users like miniserve (and maybe send them a migration PR)
The text was updated successfully, but these errors were encountered:
While this is convenient, it's problematic because:
impl Render for &PreEscaped<T>
, I'd rather go for a more general solution.std::fmt
machinery is pretty heavyweight, and buildingRender
on top of it locks us out of making it faster. In fact, this is the reason why markup.rs beats Maud in benchmarks – they use theitoa
crate to render integers.As part of this change, we should:
The text was updated successfully, but these errors were encountered: