Add support for Option<T> attributes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the examples CI looks broken. |
|
Thanks @zopieux! I'm busy right now but I'll have a look over the weekend.
Yep that's rust-lang/rust#89935 🙂 |
lambda-fairy
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Thanks @zopieux!
I have a few suggestions which should make the code simpler.
Happy to merge once those are resolved.
zopieux
force-pushed
the
attr-toggle
branch
4 times, most recently
from
e17ea0f to
b874647
Compare
Introduces the `attr=[value]` syntax that assumes `value` is an `Option<T>`. Renders `attr="value"` for `Some(value)` and entirely omits the attribute for `None`. Implements and therefore closes lambda-fairy#283.
lambda-fairy
force-pushed
the
attr-toggle
branch
from
57b4a48 to
3c9eb6c
Compare
lambda-fairy
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Thanks @zopieux!
I added a couple minor changes that you can look through if you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
attr=[value]syntax that assumesvalueis anOption<T>. Rendersattr="value"forSome(value)and entirely omits the attribute forNone.Implements and therefore closes #283.