Rust cache tests #600
Merged
Rust cache tests #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaus993
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
HermanObst,
juanbono,
Jrigada and
pefontana
as code owners
| @@ -2,7 +2,7 @@ name: benchmark_pr | |||
|
|
|||
| on: | |||
| pull_request: | |||
| branches: [ '*' ] | |||
| branches: [ 'asfd' ] | |||
There was a problem hiding this comment.
@klaus993 change this
|
Triggered manually with clean cache to compare timings. With cached deps it took 15m to run. Without it it takes 21m. This is not currently caching the target directory, so it can improve a bit more. For that we'll need to make it build all targets so other workflows can benefit as well. PS: sorry @klaus993 for destroying the other PR, I misunderstood the "tests" in the title and thought it was for testing the cache action 🤦♂️ |
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
=========================================
+ Coverage 0 94.83% +94.83%
=========================================
Files 0 60 +60
Lines 0 4144 +4144
=========================================
+ Hits 0 3930 +3930
- Misses 0 214 +214
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
force-pushed
the
rust-cache-tests
branch
from
2d04235 to
593a4aa
Compare
As explained in Swatinem/rust-cache#37, build artifacts only contribute to bloating the cache, as the divergences negate any benefits from caching them due to the cache key not changing over most commits.
Juan-M-V
approved these changes
Nov 23, 2022
azteca1998
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.