Skip to content

Commit

Permalink
Remove old todo comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
azteca1998 committed Jul 17, 2024
1 parent 6526193 commit c5999ae
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions src/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,6 @@ fn invoke_dynamic(
}

// Pad invoke data to the 16 byte boundary avoid segfaults.
// TODO: Test if the resize must be inserted before or after the data.
// TODO: If before, how in hell do we ensure alignments?
#[cfg(target_arch = "aarch64")]
const REGISTER_BYTES: usize = 64;
#[cfg(target_arch = "x86_64")]
Expand Down Expand Up @@ -339,14 +337,7 @@ fn invoke_dynamic(
if type_info.is_builtin() {
None
} else {
Some(parse_result(
ret_type,
registry,
return_ptr,
ret_registers,
// TODO: Consider returning an Option<JitValue> as return_value instead
// As cairo functions can not have a return value
))
Some(parse_result(ret_type, registry, return_ptr, ret_registers))
}
})
.unwrap_or_else(|| {
Expand Down

0 comments on commit c5999ae

Please sign in to comment.