Skip to content

Fix non native tokens updated #21

Fix non native tokens updated

Fix non native tokens updated #21

Triggered via pull request February 5, 2024 19:07
Status Failure
Total duration 54s
Artifacts

l1-contracts-ci.yaml

on: pull_request
check-verifier-generator
35s
check-verifier-generator
test-foundry
0s
test-foundry
test-hardhat
0s
test-hardhat
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 18 warnings
build
Process completed with exit code 1.
lint: l1-contracts/hardhat.config.ts#L31
Strings must use doublequote
lint: l1-contracts/hardhat.config.ts#L108
'path' is never reassigned. Use 'const' instead
lint: l1-contracts/hardhat.config.ts#L109
'rawData' is never reassigned. Use 'const' instead
lint: l1-contracts/hardhat.config.ts#L112
'jsonConfig' is never reassigned. Use 'const' instead
lint: l1-contracts/scripts/deploy-erc20.ts#L38
Delete `⏎`
lint: l1-contracts/scripts/deploy-erc20.ts#L58
Don't use `String` as a type. Use string instead
lint: l1-contracts/scripts/initialize-l2-weth-token.ts#L127
Replace `'--native-erc20'` with `"--native-erc20"`
lint: l1-contracts/scripts/initialize-l2-weth-token.ts#L127
Strings must use doublequote
check-verifier-generator
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-verifier-generator
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L33
Immutable variables name are set to be in capitalized SNAKE_CASE
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L92
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L93
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L95
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L98
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L100
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L206
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L208
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L239
Avoid to use tx.origin
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L301
Use Custom Errors instead of require statements