Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fields): add support for u64 Goldilocks #573

Closed
wants to merge 0 commits into from

Conversation

PatStiles
Copy link
Collaborator

@PatStiles PatStiles commented Sep 25, 2023

U64 Goldilocks

Description

Description of the pull request changes and motivation.

Adds support for u64 Goldilocks #393

Please delete options that are not relevant.

  • New feature

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@PatStiles PatStiles requested review from schouhy, ajgara and a team as code owners September 25, 2023 04:38
@PatStiles PatStiles marked this pull request as draft September 25, 2023 04:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #573 (68bdf05) into main (50b9fbd) will decrease coverage by 0.04%.
The diff coverage is 95.14%.

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   95.71%   95.68%   -0.04%     
==========================================
  Files         111      113       +2     
  Lines       19298    19689     +391     
==========================================
+ Hits        18471    18839     +368     
- Misses        827      850      +23     
Files Coverage Δ
...th/src/field/fields/fft_friendly/u64_goldilocks.rs 88.13% <88.13%> (ø)
math/src/field/fields/u64_goldilocks_field.rs 96.38% <96.38%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PatStiles
Copy link
Collaborator Author

@MauroToscano @schouhy ready for review

@PatStiles PatStiles marked this pull request as ready for review October 16, 2023 17:30
Comment on lines 11 to 12
// Mersenne prime numbers
// https://www.math.utah.edu/~pa/math/mersenne.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mersenne prime ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants