Feat(field): add mersenne31 field #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 97.11% 96.96% -0.16%
==========================================
Files 114 117 +3
Lines 26540 27029 +489
==========================================
+ Hits 25775 26209 +434
- Misses 765 820 +55
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
diegokingston
approved these changes
Nov 3, 2023
math/benches/fields/mersenne31.rs
Outdated
|
|
||
| #[inline(never)] | ||
| #[no_mangle] | ||
| #[export_name = "util::rand_mersenne31_field_elements"] |
There was a problem hiding this comment.
The [no_mangle] and other stuff is not necessary. Changes are similar to those in the PR for MiniGoldilocks
| if *a == Self::zero() || *a == MERSENNE_31_PRIME_FIELD_ORDER { | ||
| return Err(FieldError::InvZeroError); | ||
| } | ||
| let p101 = Self::mul(&Self::pow(a, 4u32), a); |
There was a problem hiding this comment.
Since we are doing powers of 2, it could be good at some time to implement a special version of pow to avoid the square and multiply steps
MauroToscano
reviewed
Nov 3, 2023
PatStiles
force-pushed
the
feat/mersenne31
branch
from
d32bd22 to
0ca4854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mersenne31 Field
Description
Re-opens pr #565 addressing #540 due to merge issues.
Implements the following:
TODO:
Type of change
Please delete options that are not relevant.
Checklist