This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add new constructor declare v2 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mario Rugiero <mrugiero@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 91.74% 91.82% +0.08%
==========================================
Files 54 54
Lines 12530 12728 +198
==========================================
+ Hits 11496 11688 +192
- Misses 1034 1040 +6
|
mmsc2
approved these changes
Jul 15, 2023
MegaRedHand
approved these changes
Jul 17, 2023
xqft
approved these changes
Jul 17, 2023
src/lib.rs
Outdated
| @@ -836,7 +836,7 @@ mod test { | |||
| tx_type: TransactionType::Declare, | |||
| validate_entry_point_selector: VALIDATE_DECLARE_ENTRY_POINT_SELECTOR.clone(), | |||
| version: 1.into(), | |||
| max_fee: 2, | |||
| max_fee: 100_000_000, | |||
There was a problem hiding this comment.
Suggested change
| max_fee: 100_000_000, | |
| max_fee: INITIAL_GAS_COST, |
src/lib.rs
Outdated
| let declare_tx = Transaction::DeclareV2(Box::new(declare_v2)); | ||
|
|
||
| let err = declare_tx | ||
| .execute(&mut state, &block_context, 100_000_000) |
There was a problem hiding this comment.
Suggested change
| .execute(&mut state, &block_context, 100_000_000) | |
| .execute(&mut state, &block_context, INITIAL_GAS_COST) |
Co-authored-by: Estéfano Bargas <estefano.bargas@fing.edu.uy>
Co-authored-by: Estéfano Bargas <estefano.bargas@fing.edu.uy>
pefontana
suggested changes
Jul 17, 2023
There was a problem hiding this comment.
Nice one @SantiagoPittella !
I think it would be good to add a test checking the DeclareV2.casm_class = None case.
If we already tested that case please correct me!
| @@ -466,7 +485,7 @@ mod tests { | |||
| use num_traits::{One, Zero}; | |||
|
|
|||
| #[test] | |||
| fn create_declare_v2_test() { | |||
| fn create_declare_v2_without_casm_contract_class_test() { | |||
There was a problem hiding this comment.
I would add a test with a none DeclareV2.casm_class to check that everything is working OK
pefontana
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
CasmContractClassas optional.If already exist, we do not compile de sierra to casm.
If not, we use the usual path and compile the sierra to casm.
In both cases we check the CASM class hashes.
closes #822
Made on top of #819
Checklist