-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barret reduction for modexp #170
base: main
Are you sure you want to change the base?
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e59313 - Browse repository at this point
Copy the full SHA 7e59313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9206d42 - Browse repository at this point
Copy the full SHA 9206d42View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f11e74 - Browse repository at this point
Copy the full SHA 9f11e74View commit details -
Implement Big UInt Left Shift (#139)
* Add `bigUIntShl` implementation * Add constants * Fix compilation
Configuration menu - View commit details
-
Copy full SHA for db34989 - Browse repository at this point
Copy the full SHA db34989View commit details -
Implement Big UInt Right Shift (#137)
* Add `bigUIntShr` implementation * Add constants
Configuration menu - View commit details
-
Copy full SHA for c954c0c - Browse repository at this point
Copy the full SHA c954c0cView commit details
Commits on Sep 27, 2023
-
Implement Big UInt Bitwise Or for modexp (#135)
* Implement bigUIntBitOr * Fix bigUIntBitOr * Fix bigUIntBitOr Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Fix missing closing brackets --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 16558cb - Browse repository at this point
Copy the full SHA 16558cbView commit details -
Implement big uint conditional select for modexp (#148)
* Implement bigUIntCondSelect * Fix missing curly braces Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Implement Big UInt Right Shift (#137) * Add `bigUIntShr` implementation * Add constants * Implement Big UInt Bitwise Or for modexp (#135) * Implement bigUIntBitOr * Fix bigUIntBitOr * Fix bigUIntBitOr Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Fix missing closing brackets --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b1645c0 - Browse repository at this point
Copy the full SHA b1645c0View commit details
Commits on Sep 29, 2023
-
Implement mul operation for big UInts (#151)
* First implementation of mul operation for bigints * Fix multiplication for big integers * Fix some merge issues * Improve comments and function docs * Delete whitespaces
Configuration menu - View commit details
-
Copy full SHA for 02db93f - Browse repository at this point
Copy the full SHA 02db93fView commit details
Commits on Oct 2, 2023
-
Substraction with borrow (#149)
* First substraction draft * Fix compile problems * Working implementation * Updated code * Updated code * Update subtract implementation * Remove console_log * Add docs for function * Update function docs * Remove tests from from ModExp.yul * Fix typo * Restore horrible whitespaces to avoid an ugly merge conflict * Update precompiles/Modexp.yul Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Revert "Update precompiles/Modexp.yul" This reverts commit 582bc41. --------- Co-authored-by: Joaquín P. Centeno <jpcenteno@users.noreply.github.com> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2ff02cc - Browse repository at this point
Copy the full SHA 2ff02ccView commit details
Commits on Oct 3, 2023
-
Refactor
modexp
reimplementation (#156)* Make Big UInt API functions naming consistent * Refactor `bigUIntAdd` variable names * Refactor `bigUIntMul` variable names * Refactor `subLimbsWithBorrow` * Refactor `bigUintSubtractionWithBorrow` * Refactor `bigUIntAdd` * Fix `bigUIntSubWithBorrow` * Format `storeLimbValueAtOffset` * Refactor `bigUIntBitOr` Made it consistent with the rest of the code convention and naming * Refactor `bigUIntCondSelect` Made it consistent with the rest of the code convention and naming * Reorder `overflowingSubWithBorrow` * Move comment to modexp API Docs section
Configuration menu - View commit details
-
Copy full SHA for b86bed6 - Browse repository at this point
Copy the full SHA b86bed6View commit details
Commits on Oct 5, 2023
-
* Division draft * Non working draft * Fix compile errors * Use proper pointers for quotient and remainder * Add fix note, some more changes * Add comment * Implement `big_uint_bit_size` * Increase pointer to prevent it from steping over console_log * WIP divrem * Fix loop and zero initializer * Push test cases * Add other test case * Add docs and tests for `big_uint_inplace_or_1` * Fix bug related to bit shifting * Fix borrow return in big uint sub function * Delete playground file used for debugging * Fix sub with borrow function * Add playground again to check more big integer division tests * Remove playground used for testing * Write documentation for new shift functions * Improve naming and documentation for new helper functions * Rename bigUIntOrWith1 to bigUintInPlaceOrWith1 * Add tmp buffer parameters to bigUIntDivRem. Improve docs. * Simplify subLimbsWithBorrow Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Remove `mul` call from `bigUIntInPlaceOrWith1` Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Remove multiplications from copyBigUint Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Optimize bigUIntBitSize loop Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Simplify zeroWithLimbSizeAt --------- Co-authored-by: Francisco Krause Arnim <fkrausear@gmail.com> Co-authored-by: IAvecilla <iavecilla@fi.uba.ar> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4a6a723 - Browse repository at this point
Copy the full SHA 4a6a723View commit details
Commits on Oct 6, 2023
-
Implement mul mod operation for big UInts (#161)
* Division draft * Non working draft * Fix compile errors * Use proper pointers for quotient and remainder * Add fix note, some more changes * Add comment * Implement `big_uint_bit_size` * Increase pointer to prevent it from steping over console_log * WIP divrem * Fix loop and zero initializer * Push test cases * Add other test case * Add docs and tests for `big_uint_inplace_or_1` * Fix bug related to bit shifting * Fix borrow return in big uint sub function * Delete playground file used for debugging * Fix sub with borrow function * Add playground again to check more big integer division tests * Remove playground used for testing * Write documentation for new shift functions * Improve naming and documentation for new helper functions * Rename bigUIntOrWith1 to bigUintInPlaceOrWith1 * Add tmp buffer parameters to bigUIntDivRem. Improve docs. * Add big uint mul mod skeleton * Remove wrong comment * Update algorithm comment * Add limb size doubling and divide by two for mul mod operation * Functions to duplicate and halve limb size work in place * Use camelCase * Remove console_log * Add docs * Update doc --------- Co-authored-by: Francisco Krause Arnim <fkrausear@gmail.com> Co-authored-by: Joaquín P. Centeno <jpcenteno@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 06df32c - Browse repository at this point
Copy the full SHA 06df32cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fc184d - Browse repository at this point
Copy the full SHA 1fc184dView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 174b160 - Browse repository at this point
Copy the full SHA 174b160View commit details -
Merge branch 'main' of github.com:lambdaclass/zksync_era_precompiles …
…into modexp_reimplementation
Configuration menu - View commit details
-
Copy full SHA for 92010d6 - Browse repository at this point
Copy the full SHA 92010d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 776dc1d - Browse repository at this point
Copy the full SHA 776dc1dView commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3c0f00c - Browse repository at this point
Copy the full SHA 3c0f00cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b8b2f6 - Browse repository at this point
Copy the full SHA 1b8b2f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b775975 - Browse repository at this point
Copy the full SHA b775975View commit details -
* Add free memory pointer function * Update precompiles/Modexp.yul Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> * Update precompiles/Modexp.yul Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ebc92a8 - Browse repository at this point
Copy the full SHA ebc92a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55ace22 - Browse repository at this point
Copy the full SHA 55ace22View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfbcbae - Browse repository at this point
Copy the full SHA bfbcbaeView commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4fabd3c - Browse repository at this point
Copy the full SHA 4fabd3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f51a9e - Browse repository at this point
Copy the full SHA 1f51a9eView commit details
Commits on Oct 12, 2023
-
Modexp for big UInts skeleton (#164)
* WIP: modexp skeleton * Use of mul mod function for big integers * imlement aux function to check if big uint is larger than 1 * minor fix * Restore modexp from target branch * Fix mul mod * Finish modexp implementation * Remove playground used for debugging * Update modexp with final state of modular exponentiation function * Fix merge issue * Change all names to camel case * fix typo Co-authored-by: Francisco Krause Arnim <56402156+fkrause98@users.noreply.github.com> --------- Co-authored-by: IAvecilla <iavecilla@fi.uba.ar> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> Co-authored-by: Francisco Krause Arnim <56402156+fkrause98@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 730931e - Browse repository at this point
Copy the full SHA 730931eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54fe792 - Browse repository at this point
Copy the full SHA 54fe792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ecd8a3 - Browse repository at this point
Copy the full SHA 2ecd8a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 027ccfe - Browse repository at this point
Copy the full SHA 027ccfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f69aa - Browse repository at this point
Copy the full SHA 01f69aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7da051 - Browse repository at this point
Copy the full SHA b7da051View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb07c4 - Browse repository at this point
Copy the full SHA cbb07c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e541c - Browse repository at this point
Copy the full SHA 41e541cView commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f8dd97 - Browse repository at this point
Copy the full SHA 9f8dd97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1152581 - Browse repository at this point
Copy the full SHA 1152581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84fabdb - Browse repository at this point
Copy the full SHA 84fabdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 938f5a6 - Browse repository at this point
Copy the full SHA 938f5a6View commit details
Commits on Oct 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da8f686 - Browse repository at this point
Copy the full SHA da8f686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f6f6ae - Browse repository at this point
Copy the full SHA 4f6f6aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 385fbf2 - Browse repository at this point
Copy the full SHA 385fbf2View commit details
Commits on Oct 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 961c3aa - Browse repository at this point
Copy the full SHA 961c3aaView commit details
Commits on Oct 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 633447a - Browse repository at this point
Copy the full SHA 633447aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc40942 - Browse repository at this point
Copy the full SHA cc40942View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4defc61 - Browse repository at this point
Copy the full SHA 4defc61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e358ba - Browse repository at this point
Copy the full SHA 0e358baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 453747b - Browse repository at this point
Copy the full SHA 453747bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f6424a - Browse repository at this point
Copy the full SHA 6f6424aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c12d0 - Browse repository at this point
Copy the full SHA a7c12d0View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bf6a8e2 - Browse repository at this point
Copy the full SHA bf6a8e2View commit details
Commits on Oct 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6fc4dfd - Browse repository at this point
Copy the full SHA 6fc4dfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5754a9 - Browse repository at this point
Copy the full SHA c5754a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 981e462 - Browse repository at this point
Copy the full SHA 981e462View commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dccb796 - Browse repository at this point
Copy the full SHA dccb796View commit details
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 45af45a - Browse repository at this point
Copy the full SHA 45af45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a3fb62 - Browse repository at this point
Copy the full SHA 9a3fb62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dd345a - Browse repository at this point
Copy the full SHA 7dd345aView commit details
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cef359b - Browse repository at this point
Copy the full SHA cef359bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e27a09c - Browse repository at this point
Copy the full SHA e27a09cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 859435c - Browse repository at this point
Copy the full SHA 859435cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdcd6c6 - Browse repository at this point
Copy the full SHA fdcd6c6View commit details