Merge pull request #27 from rome-user/patch-log-expr

Wrap `log-expr` in a conditional to assist DCE
lambdaisland · Mar 24, 2023 · 109b82e · 109b82e
2 parents 7c85abd + 8260a01
commit 109b82e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@
 
 ## Changed
 
+- Modified an internal function so that code emitted by logging macros can be
+  DCE'd when the user disables logging.
+
 # 1.2.164 (2022-11-25 / 9a89583)
 
 ## Added

diff --git a/src/lambdaisland/glogi.clj b/src/lambdaisland/glogi.clj
@@ -3,13 +3,14 @@
 (defn- log-expr [form level keyvals]
   (let [keyvals-map (apply array-map keyvals)
         formatter (::formatter keyvals-map 'identity)]
-    `(log ~(::logger keyvals-map (str *ns*))
-          ~level
-          (~formatter
-           ~(-> keyvals-map
-                (dissoc ::logger)
-                (assoc :line (:line (meta form)))))
-          ~(:exception keyvals-map))))
+    `(when ~(with-meta 'goog.debug.LOGGING_ENABLED {:tag 'boolean})
+       (log ~(::logger keyvals-map (str *ns*))
+            ~level
+            (~formatter
+             ~(-> keyvals-map
+                  (dissoc ::logger)
+                  (assoc :line (:line (meta form)))))
+            ~(:exception keyvals-map)))))
 
 (defmacro shout [& keyvals]
   (log-expr &form :shout keyvals))