Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Icons (especially around JavaScript ecosystem) #20

Merged

Conversation

AsPulse
Copy link
Contributor

@AsPulse AsPulse commented Jun 4, 2023

Subject says it all.

Here is screenshot of diff:
image

Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It seems the JSON is not sorted and CI fails so please fix it.

@AsPulse
Copy link
Contributor Author

AsPulse commented Jun 6, 2023

Sorry, I fixed it in de07736 !

I made the shell script that sorts json by keys assets/json/sort.js for only me (requires jq) in 7507d9d .
Would you mind if I include the change to this PR?
(If you regard it as inappropriate, feel free to revert the commit!)

@AsPulse AsPulse requested a review from lambdalisue June 6, 2023 09:07
Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the shell script that sorts json by keys assets/json/sort.js for only me (requires jq) in 7507d9d .
Would you mind if I include the change to this PR?
(If you regard it as inappropriate, feel free to revert the commit!)

Thanks but please remove it.

@AsPulse
Copy link
Contributor Author

AsPulse commented Jun 6, 2023

I made the shell script that sorts json by keys assets/json/sort.js for only me (requires jq) in 7507d9d .
Would you mind if I include the change to this PR?
(If you regard it as inappropriate, feel free to revert the commit!)

Thanks but please remove it.

Ok, I did it.
Thank you too for taking your time…… .ᐟ.ᐟ.ᐟ

@lambdalisue lambdalisue merged commit b5b5947 into lambdalisue:master Jun 7, 2023
@AsPulse AsPulse deleted the feat/icons-around-js-ecosystems branch June 7, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants