update geos, proj, and gdal versions; fix issue with which tag gets used #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
commented
Jan 31, 2024
•
philvarner
commented
- Update versions of geos, proj, and gdal
- Correctly use the "tag" of the image rather than the full gdal version in the scripts and dockerfiles. I'm unsure how this ever worked.
| @@ -15,7 +15,7 @@ docker buildx build \ | |||
|
|
|||
| docker buildx build \ | |||
| --platform=linux/amd64 \ | |||
| --build-arg GDAL_VERSION=${GDAL_VERSION} \ | |||
| --build-arg GDAL_VERSION_TAG=${GDAL_VERSION_TAG} \ | |||
| --build-arg RUNTIME_VERSION=${RUNTIME_VERSION} \ | |||
| -f dockerfiles/runtimes/${RUNTIME} \ | |||
| -t ghcr.io/lambgeo/lambda-gdal:${GDAL_VERSION_TAG}-${RUNTIME}${RUNTIME_VERSION} . | |||
There was a problem hiding this comment.
Correctly use the "tag" of the image rather than the full gdal version in the scripts and dockerfiles. I'm unsure how this ever worked.
I don't think the build.sh script is used anymore
| ARG RUNTIME_VERSION | ||
|
|
||
| FROM ghcr.io/lambgeo/lambda-gdal:${GDAL_VERSION} as gdal | ||
| FROM ghcr.io/lambgeo/lambda-gdal:${GDAL_VERSION_TAG} as gdal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.