Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support of passwordrules option to password element rendering #186

Closed
wants to merge 1 commit into from

Conversation

necromant2005
Copy link

Adding support of passwordrules option for password element based on apple and 1password recommendation https://developer.apple.com/password-rules/

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA yes

Description

1password and Apple support options for automatic password generation for this they are using option password rules
e.q.
<input type="password" passwordrules="minlength: 8; maxlength: 36; required: lower; required: upper; required: digit; required: [-];">
it will allow automatically generate password like: "suhxe6-buwBum-zakvab", "hegxop-6ranqa-dIzkem"
All of this provides easier path for users who struggle to generate suitable password

  • added option "passwordrules" to attributes supported by View/Helper/Password
  • in order to reproduce build element password with password rules attribute
  • expectation: view/helper/password renders option passwordrules appear
  • tests to cover this case - added

@Slamdunk
Copy link
Contributor

Slamdunk commented Aug 4, 2022

To be honest, I'm not enthusiast about this: https://github.com/mozilla/standards-positions/pull/402/files

@froschdesign
Copy link
Member

Even though I really like the fact that the possible attributes are kept up to date, but the current status of the passwordrules attribute is only a proposal. (See: whatwg/html#3518)

If the attribute is needed then it can be added as a valid attribute to the view helper. A factory or delegator can help here.

@necromant2005
Copy link
Author

Safari is already support it, other browsers are coming

@Slamdunk
Copy link
Contributor

Slamdunk commented Aug 8, 2022

other browsers are coming

Mozilla considers it harmful as per link https://github.com/mozilla/standards-positions/pull/402/files :\

@Ocramius
Copy link
Member

Ocramius commented Aug 8, 2022

Can totally stay behind Mozilla's choice here.

@Ocramius Ocramius added Enhancement Feature Request Won't Fix This will not be worked on labels Aug 8, 2022
@Ocramius Ocramius self-assigned this Aug 8, 2022
@Ocramius Ocramius closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants