Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 3.19.2 into 3.20.x #268

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Merge release 3.19.2 into 3.20.x #268

merged 10 commits into from
Feb 19, 2024

Commits on Feb 1, 2024

  1. Create failing test when FormSelect without view attached tries to re… 

    …nder a hidden field

Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5d16f1c View commit details
    Browse the repository at this point in the history

  2. Avoid TypeError when view isn't attached to FormSelect 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7b8571b View commit details
    Browse the repository at this point in the history

  3. Create failing test for FormSelect without renderer attached 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d0b08d5 View commit details
    Browse the repository at this point in the history

  4. Avoid TypeError if helper doesn't have renderer attached. Create a Fo… 

    …rmSelect if needed

Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a8d6aa6 View commit details
    Browse the repository at this point in the history

  5. Avoid TypeError if helper doesn't have renderer attached. 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b92cb1a View commit details
    Browse the repository at this point in the history

  6. Coding standards fixes 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d477096 View commit details
    Browse the repository at this point in the history

  7. Don't use same class twice with different names 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3832da7 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Additional consistency with other helper getters. 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    49bd34c View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Requested changes to booleans in if conditions 

    Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
    @oldpec
    oldpec committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0d7ebcb View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge pull request #266 from oldpec/helper-optional-renderer-concistency 

    Helper optional renderer consistency
    @Slamdunk
    Slamdunk authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f2ae01f View commit details
    Browse the repository at this point in the history