Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on zendframework/zend-loader #39

Closed
michalbundyra opened this issue Jan 15, 2020 · 9 comments · Fixed by #95
Closed

Drop dependency on zendframework/zend-loader #39

michalbundyra opened this issue Jan 15, 2020 · 9 comments · Fixed by #95

Comments

@michalbundyra
Copy link
Member

This removes the dependency on the zendframework/zend-load package, as suggested in #185

The HeaderLoader class has been removed and replaced by a simple class map in the Headers class.

However, I have also removed the getPluginClassLoader and setPluginClassLoader methods. Since they are public, this might be a BC break. What do you think?


Originally posted by @acelaya at zendframework/zend-mail#186

@michalbundyra
Copy link
Member Author

Builds are failing with latest dependencies, but they are failing in master too.

I'll try to figure out how to fix them, but it might take me time.


Originally posted by @acelaya at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

Please rebase onto develop


Originally posted by @Xerkus at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

There is a PR with fix, I will merge it shortly


Originally posted by @Xerkus at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

Perfect then. Thanks.


Originally posted by @acelaya at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

I have rebased develop. I'll do it again once you merge the other PR.


Originally posted by @acelaya at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

Just a heads up: there is a big ongoing effort going for next major versions for zend-expressive and related packages as well as for zend-mvc. This change will require a next major version, and I do not expect to get to it until february.


Originally posted by @Xerkus at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

Ok, no rush :-)


Originally posted by @acelaya at zendframework/zend-mail#186 (comment)

@michalbundyra
Copy link
Member Author

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Originally posted by @weierophinney at zendframework/zend-mail#186 (comment)

@samsonasik
Copy link
Member

I've created PR #95 for it.

samsonasik added a commit to samsonasik/laminas-mail that referenced this issue Jul 23, 2020
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik samsonasik linked a pull request Jul 23, 2020 that will close this issue
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants