Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file headers #150

Merged
merged 6 commits into from
May 11, 2021
Merged

Remove file headers #150

merged 6 commits into from
May 11, 2021

Conversation

ghostwriter
Copy link
Contributor

[QA] Remove file header (DocBlock comments)

gennadiylitvinyuk and others added 6 commits April 3, 2021 22:55
Signed-off-by: Gennadiy Litvinyuk <gennadiy@gmail.com>
Signed-off-by: Gennadiy Litvinyuk <gennadiy@gmail.com>
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
QA: Use ::class constant for getHeaderByName() calls
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@glensc
Copy link
Contributor

glensc commented May 10, 2021

@ghostwriter why?

@glensc
Copy link
Contributor

glensc commented May 10, 2021

@ghostwriter this violates project licensing:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

@Ocramius
Copy link
Member

Ocramius commented May 10, 2021 via email

@ghostwriter
Copy link
Contributor Author

@glensc It's on the TSC Agenda

...we have LICENSE and COPYRIGHT files in each repository,
and since code is installed with these files, it's up to the distributor
of code to ensure that attribution is present...

As such, we have decided to remove the DocBlocks from code files. more

@Slamdunk Slamdunk changed the base branch from 2.14.x to 2.15.x May 11, 2021 06:50
@Slamdunk Slamdunk added this to the 2.15.0 milestone May 11, 2021
@Slamdunk
Copy link
Contributor

Thanks @ghostwriter

@Slamdunk Slamdunk merged commit 9a88d00 into laminas:2.15.x May 11, 2021
@ghostwriter ghostwriter deleted the remove-file-headers branch May 11, 2021 12:08
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants