Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust documentation to avoid accumulating recipients in a loop (resulting in multiple mails received by same recipient) #191

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

bouks
Copy link
Contributor

@bouks bouks commented Jul 13, 2022

Provide a better example with changing of recipient instead of accumulating them and sending multiple times to each recipient.
Add better message instantiation and usage syntax (since PHP 5.4 !)
Remove cloning, that is unnecessary.

Fixes #189

Signed-off-by: bouks karibou@ribouka.com

Q A
Documentation yes
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Parenthesis missing and remove comment 

#189

Signed-off-by: bouks <karibou@ribouka.com>
@Ocramius Ocramius added Bug Something isn't working Documentation labels Jul 13, 2022
@Ocramius Ocramius added this to the 2.17.0 milestone Jul 13, 2022
@Ocramius Ocramius self-assigned this Jul 13, 2022
@Ocramius
Copy link
Member

@bouks I think you meant to push this to your patch-1 branch?

You should be able to edit that from the Github UI 🤔

@Ocramius Ocramius changed the title parenthesis missing Adjust documentation to avoid accumulating recipients in a loop (resulting in multiple mails received by same recipient) Jul 13, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bouks!

@Ocramius Ocramius merged commit bd7e0b7 into laminas:2.17.x Jul 13, 2022
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
Adjust documentation to avoid accumulating recipients in a loop (resulting in multiple mails received by same recipient)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc sending-multiple-mails example error
2 participants