Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PHP 8.0 syntax and property promotion #204

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com

Q A
QA yes

Description

Since we use php 8.0 as minimal requirement, we can apply php 8.0 syntax and property promotion.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik
Copy link
Member Author

All green 🎉

src/Storage/AbstractStorage.php Show resolved Hide resolved
src/Message.php Show resolved Hide resolved
src/Header/AbstractAddressList.php Show resolved Hide resolved
src/Storage/Folder.php Outdated Show resolved Hide resolved
src/Storage/Folder.php Show resolved Hide resolved
src/Storage/Part.php Show resolved Hide resolved
@Ocramius Ocramius added this to the 2.17.0 milestone Aug 6, 2022
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
src/Storage/Folder.php Outdated Show resolved Hide resolved
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once green 👍

@Ocramius Ocramius self-assigned this Aug 6, 2022
@Ocramius
Copy link
Member

Ocramius commented Aug 6, 2022

Thanks @samsonasik!

@Ocramius Ocramius merged commit bf75042 into laminas:2.17.x Aug 6, 2022
@samsonasik samsonasik deleted the apply-php8 branch August 6, 2022 12:27
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
Apply PHP 8.0 syntax and property promotion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants