Fixes #23 ensure trim() on ContentType::addParameter() #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Closed
|
travis build green 🎉 |
weierophinney
added a commit
that referenced
this pull request
Jul 28, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
IMHO this is fixed in the wrong place. the trim should be in a call to addParameter not in addParameter itself. |
|
@glensc Please open separate PR and link to this issue. As it is closed already can be easily missed. Thanks! |
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description
Fixes #23 ensure
trim()onContentType::addParameter()soContentType::getParameter("name")will always get correct result.