Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPUnit 10 #184

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Update to PHPUnit 10 #184

merged 1 commit into from
Mar 21, 2023

Conversation

Slamdunk
Copy link
Contributor

Blocked by #183

@Ocramius Ocramius added this to the 3.21.0 milestone Mar 21, 2023
@Ocramius
Copy link
Member

Needs a small rebase, then good to go 👍

Signed-off-by: Filippo Tessarotto <zoeslam@gmail.com>
@Slamdunk Slamdunk marked this pull request as ready for review March 21, 2023 13:42
@Slamdunk
Copy link
Contributor Author

Done

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @Slamdunk!

@Ocramius Ocramius merged commit 004b2dc into laminas:3.21.x Mar 21, 2023
@Slamdunk Slamdunk deleted the phpunit_10 branch March 21, 2023 14:03
@Ocramius
Copy link
Member

@boesing I'll hold back a release based on your feedback: you did loads of patches, and I lost the flow here :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants