-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.3 #207
Conversation
Should work, targeting latest 3.x branch, create new minor, merge-up to v4, create new RC. We also need |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
4231bdb
to
cf9d79c
Compare
a0f510c
to
cf9d79c
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
…schema in-place Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@@ -18,4 +11,9 @@ | |||
<group>disable</group> | |||
</exclude> | |||
</groups> | |||
<source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laminas/technical-steering-committee any ideas (besides "do not run tests on latest") to somehow have tests not failing on "latest" when phpunit changes config? No clue why sebastian is dropping still compatible (but deprectated) configuration flags entirely even tho they still work...
So config was valid, even for the "latest" version but as per the schema, it was not.
Should I ask in phpunit why there are config flags dropped from the schema instead of marking them deprecated? Does XSD even support the concept of "deprecated"?
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
1d8e39b
to
4fcfc29
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
4fcfc29
to
eb09e53
Compare
Thanks, @glo71317! |
Description