Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.3 #207

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Add support for PHP 8.3 #207

merged 6 commits into from
Oct 10, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@froschdesign
Copy link
Member

@glo71317
Please use the following branch: 3.22.x

@boesing
Will this work or is there something else that needs to be considered or is there another plan for how to proceed?

@boesing
Copy link
Member

boesing commented Oct 10, 2023

Should work, targeting latest 3.x branch, create new minor, merge-up to v4, create new RC.
I can take over here when I find some time, maybe this weekend.

We also need ignore_php_platform_requirements in the .laminas-ci.json where we add 8.3 to avoid transitive dependency incompatibilities. We do want to verify if this package is compatible, we do not (yet) care about transitive dependencies until these packages have issues with PHP 8.3 and do have impact on this component

@boesing boesing self-assigned this Oct 10, 2023
@glo71317 glo71317 changed the base branch from 4.0.x to 3.22.x October 10, 2023 17:49
@glo71317 glo71317 changed the base branch from 3.22.x to 4.0.x October 10, 2023 17:50
@glo71317

This comment was marked as outdated.

@boesing boesing mentioned this pull request Oct 10, 2023
glo71317 and others added 2 commits October 10, 2023 21:32
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing changed the base branch from 4.0.x to 3.22.x October 10, 2023 19:34
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member

boesing commented Oct 10, 2023

README linting is fixed in #210

…schema in-place

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@@ -18,4 +11,9 @@
<group>disable</group>
</exclude>
</groups>
<source>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laminas/technical-steering-committee any ideas (besides "do not run tests on latest") to somehow have tests not failing on "latest" when phpunit changes config? No clue why sebastian is dropping still compatible (but deprectated) configuration flags entirely even tho they still work...
So config was valid, even for the "latest" version but as per the schema, it was not.
Should I ask in phpunit why there are config flags dropped from the schema instead of marking them deprecated? Does XSD even support the concept of "deprecated"?

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the php8.3_support branch 2 times, most recently from 1d8e39b to 4fcfc29 Compare October 10, 2023 21:01
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member

boesing commented Oct 10, 2023

Thanks, @glo71317!

@boesing boesing added this to the 3.22.0 milestone Oct 10, 2023
@boesing boesing merged commit b4f5470 into laminas:3.22.x Oct 10, 2023
14 of 15 checks passed
@boesing boesing changed the title PHP 8.3 support added Add support for PHP 8.3 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants