QA: Bumps Dependencies and Improves Static Analysis #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drops PHP 7.3 - Drops Service Manager v2 - Updates latest dev dependencies - Adds template types for plugin manager - Fixes newly surfaced type errors Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Jun 13, 2022
src/ValidatorPluginManager.php
Outdated
| @@ -239,7 +248,7 @@ class ValidatorPluginManager extends AbstractPluginManager | |||
| \Zend\Validator\Bitwise::class => Bitwise::class, | |||
| \Zend\Validator\Callback::class => Callback::class, | |||
| \Zend\Validator\CreditCard::class => CreditCard::class, | |||
| \Zend\Validator\Csrf::class => Csrf::class, | |||
| \zend\validator\csrf::class => Csrf::class, | |||
There was a problem hiding this comment.
Eagle eyes! I'm blaming phpcbf for that!
Signed-off-by: George Steel <george@net-glue.co.uk>
boesing
requested changes
Jun 14, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
|
Is something wrong with the laminas-ci action 1.20 release? - Everything is passing locally |
|
Yup: new got version broke everything 😩 We need to patch it to add https://stackoverflow.com/questions/71849415/i-cannot-add-the-parent-directory-to-safe-directory-in-git/71904131#71904131 to it. |
This was referenced Jun 14, 2022
|
FWIW, raised laminas/laminas-continuous-integration-action#95, need a review :) |
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Jun 14, 2022
Ocramius
approved these changes
Jun 14, 2022
michalbundyra
added a commit
to michalbundyra/laminas-validator
that referenced
this pull request
Mar 4, 2024
Pretty unsure why it was moved from dev dependencies in laminas#129, but it seems to be wrong. Still suggest section states: > "laminas/laminas-servicemanager": "Laminas\\ServiceManager component to allow using the ValidatorPluginManager and validator chains", so it is optional dependency and we should not be forced to install it, when we do not need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description