Refactor Barcode validator
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
v3/refactor-barcode
branch
from
5f52792 to
75966dc
Compare
gsteel
added a commit
to gsteel/laminas-validator
that referenced
this pull request
Jun 25, 2024
See laminas#291 Signed-off-by: George Steel <george@net-glue.co.uk>
- Removes all options setters and getters - Allows class-string for the adapter - Drops options for the adapters because none of them accepted options - Drop the abstract adapter and simplify adapter interface - Remove most getters/setters for adapters - extract useful checksum methods from the abstract adapter to an internal utility class Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v3/refactor-barcode
branch
from
75966dc to
718f9ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description