NotEmpty Validator Input Filter Affordances
#396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
not-empty-message-templates
branch
from
cae7035 to
e1ef49f
Compare
|
If I can get an approving review from @laminas/technical-steering-committee, then I think we can release v3.0 today 🤞 |
Ocramius
approved these changes
Oct 21, 2024
InputFilter needs access to the internal message templates of the `NotEmpty` validator in order to present error messages when a required field is empty. This patch re-introduces `getMessageTemplates` only on the NotEmpty validator and marks the method as internal. Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
not-empty-message-templates
branch
from
e1ef49f to
f0187df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InputFilter needs access to the internal message templates of the
NotEmptyvalidator in order to present error messages when a required field is empty. This patch re-introducesgetMessageTemplatesonly on the NotEmpty validator and marks the method as internal.https://github.com/laminas/laminas-inputfilter/blob/15e25a10db958c4f12b3eda19ae47f38d193eb58/src/Input.php#L457-L481