Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options handling bug in Hash validator preventing the use of non-default algorithms #399

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

InvisibleSmiley
Copy link

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes issue #398.

Signed-off-by: Jens Hatlak <jens.hatlak@check24.de>
@froschdesign froschdesign added the Bug Something isn't working label Nov 26, 2024
@froschdesign froschdesign requested a review from gsteel November 26, 2024 20:58
@froschdesign froschdesign added this to the 2.65.0 milestone Nov 26, 2024
@gsteel gsteel changed the base branch from 2.65.x to 2.64.x November 26, 2024 21:26
@gsteel gsteel modified the milestones: 2.65.0, 2.64.2 Nov 26, 2024
@gsteel gsteel self-assigned this Nov 26, 2024
@gsteel gsteel changed the title Fix issue 398 Fix options handling bug in Hash validator preventing the use of non-default algorithms Nov 26, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @InvisibleSmiley :)

@gsteel gsteel merged commit 771e504 into laminas:2.64.x Nov 26, 2024
14 checks passed
@froschdesign
Copy link
Member

Sorry, I added the wrong version for the bugfix. 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algorithm passed to Hash is only used if algorithm key is provided before hash key
4 participants