Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pi value typo. #456

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix Pi value typo. #456

merged 1 commit into from
Dec 18, 2024

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Nov 26, 2024 •
edited
Loading

I assume this was a simple typo, but since it didn't use the PI macro either, I just wanted to double check in case it wasn't @finneyj.

@github-actions GitHub Actions
Copy link

Build diff

Base commit: 6ac8666c0100b19551ddb7c2acf007b8950fe9b3
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/12037226890

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

microbit-carlos
microbit-carlos commented Dec 18, 2024
View reviewed changes
Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @finneyj in a call and this is good to be merged.

@microbit-carlos microbit-carlos merged commit 73329ce into master Dec 18, 2024
29 checks passed
@microbit-carlos microbit-carlos deleted the pi-typo branch December 18, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finneyj finneyj Awaiting requested review from finneyj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microbit-carlos