Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error when older versions of tokio were used #1971

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

westonpace
Copy link
Contributor

In some versions of tokio SendError<T> only implements Debug if T is Debug (and we can't easily do that here because T contains Reader which is not Debug). So, instead, we just panic directly. The SendError wouldn't contain any additional useful information anyways.

@westonpace westonpace merged commit 6ec21f3 into lancedb:main Feb 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants