feat: expose migration check #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Mar 15, 2024
python/src/lib.rs
Outdated
| let dataset_ref = &dataset.as_ref(py).borrow().ds; | ||
| let manifest = RT | ||
| .block_on(Some(py), dataset_ref.latest_manifest())? | ||
| .map_err(|err| PyIOError::new_err(format!("Failed to connect to data: {}", err)))?; |
There was a problem hiding this comment.
This seems a little odd as an error message?
Oh this is for index migration? I should check the conditions for that too. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
=======================================
Coverage ? 80.70%
=======================================
Files ? 160
Lines ? 47127
Branches ? 47127
=======================================
Hits ? 38035
Misses ? 6931
Partials ? 2161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a utility function to check whether a Dataset's manifest needs a migration to be considered the latest version. Most users have no business calling this, so it's kept in the private module.