Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more validation of fragments #2203

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

wjones127
Copy link
Contributor

@wjones127 wjones127 commented Apr 16, 2024

As discussed in #2186

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 81.18%. Comparing base (0ef8743) to head (7ea2f0b).

Files Patch % Lines
rust/lance/src/dataset/fragment.rs 57.14% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   81.21%   81.18%   -0.03%     
==========================================
  Files         184      184              
  Lines       52208    52238      +30     
  Branches    52208    52238      +30     
==========================================
+ Hits        42401    42411      +10     
- Misses       7366     7388      +22     
+ Partials     2441     2439       -2     
Flag Coverage Δ
unittests 81.18% <57.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 marked this pull request as ready for review April 16, 2024 03:55
@wjones127 wjones127 merged commit 7b1b960 into lancedb:main Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants