Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: re-enable late materialization on full scans #2290

Merged

Conversation

westonpace
Copy link
Contributor

This also fixes the "disable pushdown if custom batch size requested" logic which wasn't working correctly. I also added a test to ensure that we are getting the benefits we expect.

@westonpace
Copy link
Contributor Author

westonpace commented May 2, 2024

Leaving in draft until #2288 (a prereq) is merged

@westonpace westonpace force-pushed the perf/fix-late-materialization-full-scan branch from 39fdb80 to dea7b33 Compare May 2, 2024 23:15
@westonpace westonpace requested a review from wjones127 May 2, 2024 23:15
@westonpace westonpace marked this pull request as ready for review May 2, 2024 23:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.51196% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 80.67%. Comparing base (be4110d) to head (65bc2cd).

Files Patch % Lines
rust/lance/src/utils/test.rs 45.88% 32 Missing and 14 partials ⚠️
rust/lance/src/dataset/scanner.rs 99.19% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
+ Coverage   80.66%   80.67%   +0.01%     
==========================================
  Files         191      191              
  Lines       56113    56308     +195     
  Branches    56113    56308     +195     
==========================================
+ Hits        45262    45426     +164     
- Misses       8319     8340      +21     
- Partials     2532     2542      +10     
Flag Coverage Δ
unittests 80.67% <77.51%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for good tests.

@westonpace westonpace merged commit b63da09 into lancedb:main May 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants