Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(java): build JNI release package #2516

Merged
merged 36 commits into from
Jul 13, 2024
Merged

ci(java): build JNI release package #2516

merged 36 commits into from
Jul 13, 2024

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 24, 2024

Provide a Github action workflow to release multi-platform JNI.

We will keep releasing 0.0.x version until Java SDK has decent feature parity.

@github-actions github-actions bot added ci Github Action or Test issues java labels Jun 24, 2024
@eddyxu eddyxu changed the title ci: build JNI release package ci(java): build JNI release package Jun 24, 2024
@eddyxu eddyxu requested a review from LuQQiu June 24, 2024 18:22
@eddyxu eddyxu marked this pull request as ready for review June 24, 2024 20:05
@LuQQiu
Copy link
Collaborator

LuQQiu commented Jun 26, 2024

#2524
After add an extra step to set up nodejs 16 instead of default 20

      - name: Set up Node.js 16
        uses: actions/setup-node@v4
        with:
          node-version: '16'

the created jar can be used without the glibc issue
validated in linux x86 ubuntu 22 spark job

- .github/workflows/java-publish.yml

jobs:
macos-arm64:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i felt like it should not be 3 jobs. but instead we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?

this will still release 3 different JAR IIUC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, if we call mvn deploy in three different job, we have to release 3 different jars (with different names?).
I am not sure that mvn will resolve dependency based on the system, like what pypi does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?

Put them into separate jobs, so that i can pass upload-artifcat/download-artifcat between the jobs. If we just run 3 parallel metrics, we need the 4th one to download the artifact?

eddyxu and others added 6 commits July 10, 2024 10:09
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
- replace RoaringBitmap with BitVec
- use pool to avoid allocating bitset for each query with prefilter
- fall back to flat search if too many rows filtered out
- prefetch with flat search

---------

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This PR adds a new kind of scalar index, the LABEL_LIST scalar index. A
label list index can only be created on list columns (the item data type
has to be one of the data types that can be used for btree/bitmap
indices). The label list index can speed up array_has_any and
array_has_all queries.

This is useful for tag-like columns where each row has some number of
labels and the overall cardinality of the labels is relatively low (the
index in-memory size will depend on the cardinality of the labels).

This PR also introduces the idea that different scalar indices may
support different types of queries. There is now `SargableQuery` (what
is used by btree and bitmap) and `LabelListQuery` (used by the new label
list index). Going forward we should probably break the FullTextQuery
out of `SargableQuery` and into its own query type.
@eddyxu eddyxu merged commit 8cab512 into main Jul 13, 2024
13 checks passed
@eddyxu eddyxu deleted the lei/jni_multiplatform branch July 13, 2024 08:41
@walterddr
Copy link
Contributor

i think the problem is similar to: rust-lang/rust#57497 <-- during the CI pipeline somehow GLIBC_VERSION 2.38 was pulled in. but it is not actually a package available in ubuntu. so unless we also setup rust build env in the same i wasn't able to do so. could we detect which step in the CI job actually pull in the GLIBC 2.38? if so i can replicate the step on the other CI side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Github Action or Test issues java python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants