perf: change scalar index to return RowIdTreeMap instead of u64 array #2587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering paths that use scalar indices are all built to use
RowIdTreeMap
. Scalar indices were built to useUInt64Array
. This means we have to copy from one to the other (an O(N log(N)) operation. When we just had btree indices this was a fairly cheap operation since the indices shouldn't be returning large #'s of rows anyways. Now that we haveBITMAP
andLABEL_LIST
we can have indices that return very large #'s of rows and this copy was expensive. By changing the scalar indices to useRowIdTreeMap
directly we skip the conversion.NOTE: any
LABEL_LIST
orBITMAP
index that was previously created will be invalid and will need to be recreated. Since we haven't had an official release of these index types I am not considering this a breaking change.