feat: add some basic primitives for working with repdef data #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
+ Coverage 77.93% 78.03% +0.10%
==========================================
Files 231 232 +1
Lines 70641 71044 +403
Branches 70641 71044 +403
==========================================
+ Hits 55051 55439 +388
- Misses 12439 12473 +34
+ Partials 3151 3132 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| //! | - | 1 | // Start of new inner-most list (empty list) | ||
| //! | 2 | 1 | // Start of new inner-most list | ||
| //! | 3 | 2 | // Start of new middle list | ||
| //! | - | 2 | // Start of new inner-most list (empty list) |
There was a problem hiding this comment.
Start of new middle list?
| //! | ||
| //! Definition levels are simpler. We can think of them as zipping together various validity (from | ||
| //! different levels of nesting) into a single buffer. For example, we could zip the arrays | ||
| //! [1, 1, 0, 0] and [1, 0, 1, 0] into [11, 10, 01, 00]. However, 00 and 01 are redundant. If the |
There was a problem hiding this comment.
Suggested change
| //! [1, 1, 0, 0] and [1, 0, 1, 0] into [11, 10, 01, 00]. However, 00 and 01 are redundant. If the | |
| //! [1, 1, 0, 0] and [1, 0, 1, 0] into [11, 10, 01, 00]. However, 00 and 01 have redundancy in them. If the |
Suggested change
| //! [1, 1, 0, 0] and [1, 0, 1, 0] into [11, 10, 01, 00]. However, 00 and 01 are redundant. If the | |
| //! [1, 1, 0, 0] and [1, 0, 1, 0] into [11, 10, 01, 00]. However, 00 and 01 are redundant. If the |
westonpace
force-pushed
the
feat/repdef-primitives
branch
from
695b2d5
to
af549ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds builders for repetition and definition levels and also adds a miniblock concept for zipping together multiple buffers.