feat: allow scalar indices to be disabled for a query #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebbyChefNEQ
approved these changes
Sep 26, 2024
ankitvij-db
pushed a commit
to ankitvij-db/lance
that referenced
this pull request
Sep 26, 2024
There are some cases today where scalar indices can make query performance worse. This is usually when a scalar index search has many results (e.g. "x != 7"). Ideally, we will fix our planner to not use the scalar index in this case. However, even if we do that, there will probably be cases where it would be nice (for debugging purposes if nothing else) to be able to disable the scalar index for a query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases today where scalar indices can make query performance worse. This is usually when a scalar index search has many results (e.g. "x != 7"). Ideally, we will fix our planner to not use the scalar index in this case. However, even if we do that, there will probably be cases where it would be nice (for debugging purposes if nothing else) to be able to disable the scalar index for a query.