Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve datafusion SQL planning and parsing errors #2959

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Sep 30, 2024

Show as invalid input instead of server internal error

@github-actions github-actions bot added the chore label Sep 30, 2024
@wjones127 wjones127 changed the title chore: improve data-fusion SQL planing and parsing errors feat: improve datafusion SQL planning and parsing errors Sep 30, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 30, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.27907% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (4e40ed6) to head (4093931).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-core/src/error.rs 25.92% 20 Missing ⚠️
rust/lance-datafusion/src/planner.rs 0.00% 15 Missing ⚠️
rust/lance-datafusion/src/logical_expr.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2959      +/-   ##
==========================================
+ Coverage   77.75%   78.95%   +1.19%     
==========================================
  Files         231      234       +3     
  Lines       70485    72851    +2366     
  Branches    70485    72851    +2366     
==========================================
+ Hits        54808    57520    +2712     
+ Misses      12773    12348     -425     
- Partials     2904     2983      +79     
Flag Coverage Δ
unittests 78.95% <16.27%> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. There's a lot of errors throughout the codebase that were just left as Error:IO.

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Sep 30, 2024

Thanks for reviewing the PR!!

@LuQQiu LuQQiu merged commit 8d58258 into lancedb:main Sep 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants