Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error for concurrent create #2962

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

wjones127
Copy link
Contributor

Fixes #2403

@github-actions github-actions bot added the bug Something isn't working label Sep 30, 2024
Comment on lines +146 to +147
// TODO: Allow Append or Overwrite mode to retry using `commit_transaction`
// if there is a conflict.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up issue here: #2961

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (396b4d1) to head (1302ffd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset.rs 88.23% 0 Missing and 4 partials ⚠️
rust/lance/src/io/commit.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
+ Coverage   78.99%   79.00%   +0.01%     
==========================================
  Files         234      234              
  Lines       72829    72894      +65     
  Branches    72829    72894      +65     
==========================================
+ Hits        57530    57589      +59     
- Misses      12329    12333       +4     
- Partials     2970     2972       +2     
Flag Coverage Δ
unittests 79.00% <88.37%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit a151f32 into lancedb:main Sep 30, 2024
22 checks passed
@wjones127 wjones127 deleted the fix/concurrent-create-error branch September 30, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent create dataset gives bad error, doesn't retry
3 participants