Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline datafusion_common #2963

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: inline datafusion_common #2963

merged 3 commits into from
Oct 1, 2024

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Oct 1, 2024

Solve the
error[E0432]: unresolved import datafusion_common
--> rust/lance-core/src/error.rs:5:5
|
5 | use datafusion_common::DataFusionError;
| ^^^^^^^^^^^^^^^^^ use of undeclared crate or module datafusion_common
in
cd /rust/lance-linalg && cargo bench

@github-actions github-actions bot added the bug Something isn't working label Oct 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (a151f32) to head (bcc3ce8).

Files with missing lines Patch % Lines
rust/lance-core/src/error.rs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
+ Coverage   78.96%   78.98%   +0.01%     
==========================================
  Files         234      234              
  Lines       72916    72916              
  Branches    72916    72916              
==========================================
+ Hits        57580    57590      +10     
+ Misses      12356    12352       -4     
+ Partials     2980     2974       -6     
Flag Coverage Δ
unittests 78.98% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuQQiu LuQQiu merged commit 1e0c4f8 into lancedb:main Oct 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants