Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various fixes to get the random data tests working on 2.1 #3103

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.55556% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.86%. Comparing base (828b315) to head (11039ff).

Files with missing lines Patch % Lines
rust/lance-encoding/src/statistics.rs 0.00% 8 Missing ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 91.30% 3 Missing and 1 partial ⚠️
rust/lance-encoding/src/repdef.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   77.13%   76.86%   -0.28%     
==========================================
  Files         240      240              
  Lines       79833    79894      +61     
  Branches    79833    79894      +61     
==========================================
- Hits        61579    61410     -169     
- Misses      15082    15313     +231     
+ Partials     3172     3171       -1     
Flag Coverage Δ
unittests 76.86% <85.55%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@broccoliSpicy broccoliSpicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@broccoliSpicy broccoliSpicy merged commit 0abf7d4 into lancedb:main Nov 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants