for ChatVectorDBChain, add top_k_docs_for_context to allow control how many chunks of context will be retrieved #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have done similar project (youtube summarization and question answeirng).
I find that youtube video meta infor, especially video title and descriptions are quite helpful for LLM to better understand the context.
and similarly, thumbnail image url can be useful when build web app with this.
a sample output would be
{'source': 'I845O57ZSy4',
'title': 'John Carmack: Doom, Quake, VR, AGI, Programming, Video Games, and Rockets | Lex Fridman Podcast langchain-ai#309',
'description': 'John Carmack is a legendary programmer, co-founder of id Software, and lead programmer of many revol...',
'view_count': 1229347,
'thumbnail_url': 'https://i.ytimg.com/vi/I845O57ZSy4/sddefault.jpg',
'publish_date': datetime.datetime(2022, 8, 4, 0, 0),
'length': 18890,
'author': 'Lex Fridman',
}
Love the work you guys have done on LangChain, hope i can also contribute a tiny bit!
…ntext will be retrieved given that we allow user define chunk size, think it would be useful for user to define how many chunks of context will be retrieved. or the default 4 chunk can break some code.
Closed
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
…w many chunks of context will be retrieved (langchain-ai#1155) given that we allow user define chunk size, think it would be useful for user to define how many chunks of context will be retrieved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that we allow user define chunk size, think it would be useful for user to define how many chunks of context will be retrieved.