move serpapi wrapper #1199
Merged
move serpapi wrapper #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot of valuable data that can come from SerpAPI, more than just a single snippet or answer. Add a `results` method which returns the raw api response from serpapi. It's very useful grabbing snippets and the answer box for crafting context summaries in quality checking answers for recent or more obscure information. --- I did make a proactive move to move `SerpApiWrapper` into `langchain.utilities` since that was where the other Serp API utilities all were, and it seemed like it might have been a legacy thing. I tested that backwards compatibility was maintained with `SerpApiChain`. Also did a small amount of refactoring to bring in the `process_response` method into the class so that it was more in line with what I saw with the other utilities. If this is out of scope or not what you want, let me know, I'm fine pulling those changes out and just including the `results` method.
Closed
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Tim Asp <707699+timothyasp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.