Harrison/memory refactor #1478
Merged
Harrison/memory refactor #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
approved these changes
Mar 6, 2023
langchain/schema.py
Outdated
| @@ -133,3 +133,33 @@ def get_num_tokens(self, text: str) -> int: | |||
|
|
|||
| # calculate the number of tokens in the tokenized text | |||
| return len(tokenized_text) | |||
|
|
|||
|
|
|||
| class Memory(BaseModel, ABC): | |||
There was a problem hiding this comment.
While we're at it, might as well rename Memory to BaseMemory and add an alias for bw-compat
langchain/memory/chat_memory.py
Outdated
| self.messages = [] | ||
|
|
||
|
|
||
| class ChatMemoryMixin(Memory): |
There was a problem hiding this comment.
this isn't really a mixin -- it's a base class. Rename to BaseChatMemory? and inherit ABC
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
moves memory to own module, factors out common stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves memory to own module, factors out common stuff