Harrison/rtd loader #1513
Merged
Harrison/rtd loader #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves ReadTheDocsLoader
1. Pass initialization args to BeautifulSoup. This allows selection of
parser library - eg. `features='html5lib'`
2. `load` method gets an optional `encoding` and `error` for the file
`open` method.
This allows developers to do things like:
Original:
```
# The following line produces a BeautifulSoup warning that parser library is not specified
loader = ReadTheDocsLoader('langchain.readthedocs.io/en/latest/')
# The following could fail if encoding is not current OS encoding
raw_documents = loader.load()
```
New:
```
# features='html5lib' is passed down to BeautifulSoup allowing standard parser library
# across environments - still Optional to maintain backward compatibility
loader = ReadTheDocsLoader('langchain.readthedocs.io/en/latest/', features='html5lib')
# Specify document encoding (optional to maintain compat)
# also support errors='ignore', defaulting to None for file open function
raw_documents = loader.load(encoding='utf-8')
```
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Youssef A. Abukwaik <yousseb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.