Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add from to add texts from embeddings #1813

Merged
merged 3 commits into from
Mar 23, 2023
Merged

add from to add texts from embeddings #1813

merged 3 commits into from
Mar 23, 2023

Conversation

shibuiwilliam
Copy link
Contributor

Why

  • Since making vectors of texts can be done outside of langchain Faiss, this PR is to add functionality to pass text and its vector pair to initialize and add embedding to Faiss.

What

  • Add from_embedding method in Faiss to initialize Faiss index by passing the embeddings paired with original text made outside of the langchain.
  • Add add_embedding method to add embedding paired with original text to append the embedding made outside of the langchain.

@hwchase17 hwchase17 changed the base branch from master to harrison/from-methods March 23, 2023 03:28
@hwchase17 hwchase17 merged commit 46c46c1 into langchain-ai:harrison/from-methods Mar 23, 2023
@shibuiwilliam shibuiwilliam deleted the feature/faiss_from_embeddings branch March 23, 2023 04:07
@shenghann shenghann mentioned this pull request May 31, 2023
Merged
hwchase17 pushed a commit that referenced this pull request Jun 1, 2023
@shenghann
Add texts with embeddings to PGVector wrapper (#5500)
3bae595 
Similar to #1813 for faiss, this PR is to extend functionality to pass
text and its vector pair to initialize and add embeddings to the
PGVector wrapper.

Community members can review the PR once tests pass. Tag
maintainers/contributors who might be interested:
  - @dev2049
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@shenghann @Undertone0809
Add texts with embeddings to PGVector wrapper (langchain-ai#5500)
12670d9 
Similar to langchain-ai#1813 for faiss, this PR is to extend functionality to pass
text and its vector pair to initialize and add embeddings to the
PGVector wrapper.

Community members can review the PR once tests pass. Tag
maintainers/contributors who might be interested:
  - @dev2049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shibuiwilliam @hwchase17