Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: create individual jobs in check_diff, do max milvus testing in 3.11 #23829

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Jul 3, 2024

pickup from #23721

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:31pm

@efriis efriis added the partner label Jul 3, 2024
@efriis efriis self-assigned this Jul 3, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🔌: milvus Primarily related to Milvus vector store integration 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jul 3, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 3, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
@efriis efriis changed the title milvus: 3.12 build compat work infra: create individual jobs in check_diff, fix milvus CI failures Jul 10, 2024
Comment on lines +61 to +64
if dir_ == "libs/partners/milvus":
# milvus poetry doesn't allow 3.12 because they
# declare deps in funny way
max_python = "3.11"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efriis efriis enabled auto-merge (squash) July 10, 2024 22:34
@efriis efriis disabled auto-merge July 10, 2024 22:34
@efriis efriis changed the title infra: create individual jobs in check_diff, fix milvus CI failures infra: create individual jobs in check_diff, do max milvus testing in 3.11 Jul 10, 2024
@efriis efriis enabled auto-merge (squash) July 10, 2024 22:35
@efriis efriis merged commit 9de562f into master Jul 10, 2024
115 checks passed
@efriis efriis deleted the erick/milvus-3-12-build-compat-work branch July 10, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: milvus Primarily related to Milvus vector store integration 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant