Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch[partners] Fix check_imports bugs in pinecone and milvus #24971

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ZhangShenao
Copy link
Contributor

Fix wrong declared variables of check_imports in pinecone and milvus

@efriis efriis added the partner label Aug 2, 2024
@efriis efriis self-assigned this Aug 2, 2024
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 11:42am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🔌: milvus Primarily related to Milvus vector store integration 🔌: pinecone Primarily related to Pinecone vector store integration 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Aug 2, 2024
@ZhangShenao
Copy link
Contributor Author

@efriis Please review

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 2, 2024
@ccurme ccurme merged commit c65e489 into langchain-ai:master Aug 2, 2024
24 checks passed
@ZhangShenao ZhangShenao deleted the fix_check_imports branch August 2, 2024 14:34
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
…ain-ai#24971)

Fix wrong declared variables of `check_imports` in pinecone and milvus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: milvus Primarily related to Milvus vector store integration partner 🔌: pinecone Primarily related to Pinecone vector store integration size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants