Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch[Partners] Unified fix of incorrect variable declarations in all check_imports #25014

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

ZhangShenao
Copy link
Contributor

There are some incorrect declarations of variable has_failure in check_imports. The purpose of this PR is to uniformly fix these errors.

@efriis efriis added the partner label Aug 3, 2024
Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 4:39am

@efriis efriis self-assigned this Aug 3, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 3, 2024
@ZhangShenao ZhangShenao closed this Aug 3, 2024
@ZhangShenao ZhangShenao reopened this Aug 3, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 3, 2024
@ccurme ccurme merged commit 2c3e3dc into langchain-ai:master Aug 3, 2024
144 checks passed
@ZhangShenao ZhangShenao deleted the fix_check_imports branch August 3, 2024 23:29
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
… check_imports (langchain-ai#25014)

There are some incorrect declarations of variable `has_failure` in
check_imports. The purpose of this PR is to uniformly fix these errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants